Skip to content

MIGRATION: Python 3#69

Open
janjoswig wants to merge 2 commits into
CoAxLab:masterfrom
janjoswig:python3
Open

MIGRATION: Python 3#69
janjoswig wants to merge 2 commits into
CoAxLab:masterfrom
janjoswig:python3

Conversation

@janjoswig

Copy link
Copy Markdown

This makes the package compatible with Python 3. I changed the following:

  • Use of dict.items() instead of dict.iteritems() (same for keys and values)
  • Subgraphs are now not "freezed" anymore when using a more recent version of networkx (solves issue NetworkXError: SubGraph Views are readonly. Mutations not allowed #67 )
  • Explicite use of "latin1" encoding when unpickling with load_tree
  • Use of assertCountEqual instead of assertItemsEqual in the tests
  • Use of list() to exhaust map generator and to convert dict.values to NumPy array

All tests pass (with Python 3.8) and the quickstart example from the documentation works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant